Skip to content

Commit

Permalink
kconfig: qconf: revive help message in the info view
Browse files Browse the repository at this point in the history
Since commit 68fd110 ("kconfig: qconf: remove redundant help in
the info view"), the help message is no longer displayed.

I intended to drop duplicated "Symbol:", "Type:", but precious info
about help and reverse dependencies was lost too.

Revive it now.

"defined at" is contained in menu_get_ext_help(), so I made sure
to not display it twice.

Fixes: 68fd110 ("kconfig: qconf: remove redundant help in the info view")
Reported-by: Maxim Levitsky <[email protected]>
Signed-off-by: Masahiro Yamada <[email protected]>
  • Loading branch information
masahir0y committed Sep 20, 2020
1 parent 19b835a commit a46afd1
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions scripts/kconfig/qconf.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1108,6 +1108,11 @@ void ConfigInfoView::menuInfo(void)
if (showDebug())
stream << debug_info(sym);

struct gstr help_gstr = str_new();

menu_get_ext_help(_menu, &help_gstr);
stream << print_filter(str_get(&help_gstr));
str_free(&help_gstr);
} else if (_menu->prompt) {
stream << "<big><b>";
stream << print_filter(_menu->prompt->text);
Expand All @@ -1119,11 +1124,11 @@ void ConfigInfoView::menuInfo(void)
expr_print_help, &stream, E_NONE);
stream << "<br><br>";
}

stream << "defined at " << _menu->file->name << ":"
<< _menu->lineno << "<br><br>";
}
}
if (showDebug())
stream << "defined at " << _menu->file->name << ":"
<< _menu->lineno << "<br><br>";

setText(info);
}
Expand Down

0 comments on commit a46afd1

Please sign in to comment.