Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download tar instead of zip archive when installing nerd-fonts. #501

Closed
wants to merge 3 commits into from

Conversation

meinzer1899
Copy link
Member

@meinzer1899 meinzer1899 commented Oct 17, 2023

In release v3.0.2 (https://github.com/ryanoasis/nerd-fonts/releases/tag/v3.0.2), the release archives are also provided as .tar.xz which results in a size decrease of ~90%. zi can handle both tar and zip archives.

In release v3.0.2 (https://github.com/ryanoasis/nerd-fonts/releases/tag/v3.0.2), the release archives are also provided as .tar.xz which results in a size decrease of ~90%. zi can handle both tar and zi archives.

Signed-off-by: sebastian <[email protected]>
@trunk-io
Copy link

trunk-io bot commented Oct 17, 2023

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@github-actions github-actions bot added the documentation 📝 Solely about the documentation of the project. label Oct 17, 2023
@meinzer1899
Copy link
Member Author

meinzer1899 commented Oct 17, 2023

@ reviewer:

  • is it possible to extract the .ttf to a directory in /fonts which matches the font name, e.g. .../font/Meslo with using the id from id-as like this
zi ice if"[[ -d ${HOME}/.fonts/ttf ]] && [[ $OSTYPE = linux* ]]" \
  .....
  atclone="rm -f *Windows*; mv -vf *.ttf ${HOME}/.fonts/ttf/${id}; fc-cache -v -f" atpull"%atclone"
  .....

instead of

   atclone="rm -f *Windows*; mv -vf *.ttf ${HOME}/.fonts/ttf; fc-cache -v -f" atpull"%atclone"

@ss-o ss-o added the triage 📑 The issue is awaiting investigation. label Oct 17, 2023
@ss-o
Copy link
Member

ss-o commented Oct 17, 2023

@meinzer1899 I will do triage and update you on this 👍

@ss-o
Copy link
Member

ss-o commented Oct 18, 2023

After trying out multiple scenarios, I concluded that the install command becomes long and complex. From user feedback and related conversations, it became clear that Zi is over-engineered and has become too complex for the majority. I think the best route to continue is to simplify and promote the creation of Zsh plugins, Zi annexes and Zi packages. This is relatively easy, super flexible, and can be used/improved by others.

I think the best approach for installing fonts would be to create an annex, which would allow an easy, reliable, and flexible way to install fonts. Users would be able to install the font(s) using an annex with atclone, atpull, atinit, and atload hooks, which would do the rest when it is required and what is required. For example, the installation of fonts would look like this:

zi font'Meslo'
zi light z-shell/0

What's your opinion on this?

Copy link
Contributor

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale 👻 No activity for quite some time. label Nov 19, 2023
@github-actions github-actions bot closed this Nov 27, 2023
@ss-o
Copy link
Member

ss-o commented Dec 5, 2023

Pull Request closed and locked due to lack of activity. If you'd like to build on this closed PR, you can clone it using this method: https://stackoverflow.com/a/14969986 Then open a new PR, referencing this closed PR in your message.

@z-shell z-shell locked and limited conversation to collaborators Dec 5, 2023
@meinzer1899 meinzer1899 deleted the patch-3 branch December 6, 2023 13:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation 📝 Solely about the documentation of the project. stale 👻 No activity for quite some time. triage 📑 The issue is awaiting investigation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants