Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change eza_params #20

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Change eza_params #20

merged 1 commit into from
Nov 17, 2023

Conversation

xaocon
Copy link
Collaborator

@xaocon xaocon commented Nov 9, 2023

@xaocon
Change eza_params
c8e40eb 
* Added `all` to `color-scale` to fix breaking change
* Removed `classify` as there is a bug when combined with `icons`
  eza-community/eza#578
@xaocon
Copy link
Collaborator Author

xaocon commented Nov 9, 2023

I don't think I can add labels. If you want to fix the breaking change another way feel free to just close this and put your own in. Just wanted to get a fix in as fast as possible since this breaks ls on my machine and presumably a number of other ones once they install the new version of eza.

@xaocon xaocon mentioned this pull request Nov 9, 2023
Open
@cafkafk
Copy link

cafkafk commented Nov 10, 2023

Sorry, I wasn't aware that we introduced a breaking change? Normally we do label them correctly.

@cafkafk cafkafk mentioned this pull request Nov 10, 2023
Closed
@meinzer1899
Copy link
Member

meinzer1899 commented Nov 10, 2023 •
edited
Loading

@cafkafk maybe these infos help
grafik

@cafkafk
Copy link

cafkafk commented Nov 10, 2023

I see how I made this mistake, I assumed the breaking change in the relevant PR was just referring to changing --decay to --color-scale (--decay having never been released), and thought there was no reason to label it a breaking change. In reality, the breaking change was partially that, but also requiring an argument. If I had realized that sooner, I'd have required --color-scale to default to all, and until eza has that behavior, I'll consider that a bug. Sorry for the inconvenience!

@cafkafk cafkafk mentioned this pull request Nov 10, 2023
Closed
@xaocon
Copy link
Collaborator Author

xaocon commented Nov 10, 2023 •
edited
Loading

@cafkafk, glad you're already considering stuff like that.

@xfoxfu
Copy link

xfoxfu commented Nov 11, 2023 •
edited
Loading

For anyone who needs a workaround and is on zi/zinit, please use:

zi ice has'eza' atinit'AUTOCD=0' atload'eza_params[3]="";eza_params[7]="--color-scale=all"'
zi light z-shell/zsh-eza

@cafkafk cafkafk mentioned this pull request Nov 12, 2023
Merged
@ss-o ss-o self-assigned this Nov 17, 2023
@ss-o ss-o added the fix ⚡ Has been fixed and is therefore considered resolved. label Nov 17, 2023
@ss-o
Copy link
Member

ss-o commented Nov 17, 2023

@xaocon 👋 , thank you for your contribution!

@ss-o ss-o merged commit df296ab into z-shell:main Nov 17, 2023
@xaocon xaocon deleted the color-scale-fix branch November 20, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ss-o ss-o ss-o approved these changes

Assignees

@ss-o ss-o

Labels
fix ⚡ Has been fixed and is therefore considered resolved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xaocon @cafkafk @meinzer1899 @xfoxfu @ss-o