Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for hooks and hook for onSearch #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KieranHunt
Copy link

Implements: #36

Hey! I wanted to play around with what this API would look like and this is what I came up with. What do you think?

Outstanding questions:

  • Is this something that you'd like to add / would think is generally useful?
  • What other hooks do you think are missing? I could also see a hook for clicking on a suggestion may be helpful too.
  • Do you think I should pass something different to the onSearch hook? I think suggestions could be useful too but I didn't know if you wanted to expose that object in the contract.
  • Is this even a good way of doing this? I've very much a Vue novice.

@KieranHunt KieranHunt changed the title Add support for hooks and hook for onSearch (#36) Add support for hooks and hook for onSearch Mar 27, 2021
@KieranHunt KieranHunt changed the title Add support for hooks and hook for onSearch Add support for hooks and hook for onSearch https://github.com/z3by/vuepress-plugin-flexsearch/issues/36 Mar 27, 2021
@KieranHunt KieranHunt changed the title Add support for hooks and hook for onSearch https://github.com/z3by/vuepress-plugin-flexsearch/issues/36 Add support for hooks and hook for onSearch Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant