-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial draft of the winget extension #356
Conversation
src/modules/cmdpal/exts/Microsoft.CmdPal.Ext.WinGet/Microsoft.CmdPal.Ext.WinGet.csproj
Fixed
Show fixed
Hide fixed
src/modules/cmdpal/exts/Microsoft.CmdPal.Ext.WinGet/Microsoft.CmdPal.Ext.WinGet.csproj
Fixed
Show fixed
Hide fixed
src/modules/cmdpal/exts/Microsoft.CmdPal.Ext.WinGet/Microsoft.CmdPal.Ext.WinGet.csproj
Fixed
Show fixed
Hide fixed
src/modules/cmdpal/exts/Microsoft.CmdPal.Ext.WinGet/WindowsPackageManager.Interop/ClassModel.cs
Fixed
Show fixed
Hide fixed
...s/cmdpal/exts/Microsoft.CmdPal.Ext.WinGet/WindowsPackageManager.Interop/ClassesDefinition.cs
Fixed
Show fixed
Hide fixed
...s/cmdpal/exts/Microsoft.CmdPal.Ext.WinGet/WindowsPackageManager.Interop/ClassesDefinition.cs
Fixed
Show fixed
Hide fixed
...s/cmdpal/exts/Microsoft.CmdPal.Ext.WinGet/WindowsPackageManager.Interop/ClassesDefinition.cs
Fixed
Show fixed
Hide fixed
...soft.CmdPal.Ext.WinGet/WindowsPackageManager.Interop/WindowsPackageManagerElevatedFactory.cs
Fixed
Show fixed
Hide fixed
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@@ -190,6 +190,7 @@ | |||
closesocket | |||
CLSCTX | |||
CLSIDs | |||
Clsids |
Check warning
Code scanning / check-spelling
Ignored Expect Variant Warning
var internalSearchTask = Task.Run(() => catalog.FindPackages(opts), ct); | ||
var searchResults = await internalSearchTask; | ||
|
||
// TOOD more error handling like this: |
Check failure
Code scanning / check-spelling
Unrecognized Spelling Error
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (1)TOOD To accept these unrecognized words as correct, you could run the following commands... in a clone of the [email protected]:zadjii-msft/PowerToys.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' |
perl - 'https://github.com/zadjii-msft/PowerToys/actions/runs/12949934986/attempts/1'
OR To have the bot accept them for you, comment in the PR quoting the following line: Errors (1)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
Tested with the `command-line` tag, because there's no extensions in winget until microsoft/winget-pkgs#216685 merges Also adds a link to search in the Store, though I think that won't be as useful. Lastly - also actually fixes the tag search 😅 Builds on #356 Closes #89 Probably needs #370 to feel right
targets #355, which I need for improvements to messages
FindPackagesAsync
, to be async. The call always ends up running synchronously, so I can't hook up theoperation.Completed
event, nor the cancellation. The action is already complete!1.10-preview
of the winget com interfaces. On my framework laptop at least, theRefreshPackageCatalogAsync
API isn't yet implemented, so I need to test thatMoreCommands
being observable in the host yet. We should.nano
and the NanoLeaf app both just work.