Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate TimeDate extension from PowerToys run to CommandPalette #412

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

moooyo
Copy link

@moooyo moooyo commented Feb 7, 2025

Summary of the Pull Request

  • Migrate the existing extension TimeDate from v1 to V2

It works well. But we still need to do more thing to make it better:

  1. currently, seems we cannot add alias for non-builtin extension?
  2. how to add configuration UI for extension?

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@moooyo
Copy link
Author

moooyo commented Feb 7, 2025

Seems that there is a exising PR to do the same thing. #242

Close this PR.

@moooyo moooyo closed this Feb 7, 2025
@moooyo
Copy link
Author

moooyo commented Feb 7, 2025

Seems that there is a exising PR to do the same thing. #242

Close this PR.

Oh...ha.
I was trying to ramp up this module. So I randomly pick up one extension to try to migrate it from v1 to v2.
I'm not aware of there are someone else working on it. Haha.

But it still give me more experience about this module.

@zadjii-msft
Copy link
Owner

zadjii-msft commented Feb 11, 2025

@moooyo oh I'm actually gonna re-open yours, since we'll probably just iterate on yours going forward ☺️

EDIT: fat fingered ctrl+enter

@zadjii-msft zadjii-msft reopened this Feb 11, 2025
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

Coices

These words are not needed and should be removed ahk Breadcrumb CDEF DEVMON DEVSOURCE DGR DIIRFLAG dshow FILEINFOSIG Filterx IKs iljxck KSPROPERTY ldx lld LONGLONG LTRB majortype makecab mfplat Msimg msiquery murmurhash Pnp propvarutil reencode reencoded stl strsafe strutil subquery TMPVAR vid VIDCAP VIDEOINFOHEADER vih

Some files were automatically ignored 🙈

These sample patterns would exclude them:

^\Qsrc/modules/cmdpal/ExtensionTemplate/TemplateCmdPalExtension/deps/Microsoft.CommandPalette.Extensions/Microsoft.CommandPalette.Extensions.0.0.5.nupkg\E$
^src/modules/cmdpal/Exts/TimeDateExtension/Properties/

You should consider adding them to:

.github/actions/spell-check/excludes.txt

File matching is via Perl regular expressions.

To check these files, more of their words need to be in the dictionary than not. You can use patterns.txt to exclude portions, add items to the dictionary (e.g. by adding them to allow.txt), or fix typos.

To accept these unrecognized words as correct, update file exclusions, and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:moooyo/PowerToys-cmdpal.git repository
on the yuleng/dev1 branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' |
perl - 'https://github.com/zadjii-msft/PowerToys/actions/runs/13280330827/attempts/1'
Errors (2)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
⚠️ binary-file 3
❌ ignored-expect-variant 5

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Use setting manager to replace old setting instance ref.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants