fix: enable loading images from the same webSource #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pixelium with
|
| Latest commit: |
6f1b705
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f9ba7f38.pixelium.pages.dev |
| Branch Preview URL: | https://117-cannot-load-image-twice.pixelium.pages.dev |
stropitek
reviewed
May 23, 2024
There was a problem hiding this comment.
As discusesd, the webSource prop of Pixelium is a hack to have access to pixelium's reducer.
My advice is to separate Pixelium into 2 components:
PixeliumProviderwhich contains the various providers needed by the pixelium UI.PixeliumAppwith the pixelium UI
This way the sidebar in between can directly load files into pixelium's state.
stropitek
reviewed
Jun 5, 2024
stropitek
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #117