Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve information panel #56

Merged
merged 3 commits into from
Aug 25, 2023
Merged

feat: improve information panel #56

merged 3 commits into from
Aug 25, 2023

Conversation

wadjih-bencheikh18
Copy link
Member

closes : #55

@wadjih-bencheikh18 wadjih-bencheikh18 linked an issue Aug 17, 2023 that may be closed by this pull request
Use InfoPanel #55
Closed
@lpatiny lpatiny mentioned this pull request Aug 18, 2023
Closed
@stropitek
Copy link
Contributor

stropitek commented Aug 22, 2023 •
edited
Loading

@wadjih-bencheikh18 can you push something so that we get a preview?

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 22, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 52a8fc1
Status: ✅  Deploy successful!
Preview URL: https://d4b2b8ac.pixelium.pages.dev
Branch Preview URL: https://55-use-infopanel.pixelium.pages.dev

View logs

@wadjih-bencheikh18
Copy link
Member Author

we get a preview?

The preview is ready

lpatiny
lpatiny approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@lpatiny lpatiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionality is ok

@lpatiny lpatiny requested a review from stropitek August 23, 2023 15:57
@stropitek
Copy link
Contributor

@wadjih-bencheikh18 there is a conflict

@lpatiny lpatiny changed the title Impove information panel feat: improve information panel Aug 24, 2023
@stropitek
Copy link
Contributor

Since package.json has not changed with respect to main, I don't think there should be changes in the package-lock.json. During the merge you should have kept the package-lock.json as it is on main

@Xstoudi
Copy link
Collaborator

Xstoudi commented Aug 25, 2023

The changes in package-lock.json are probably justified because the project use react-swc which is a native module.

@targos
Copy link
Member

targos commented Aug 25, 2023

Normally I would agree with @stropitek, but the lockfile was broken a while ago in fc02444. There is a bug in npm that sometimes generates a wrong lockfile but it's very hard to reproduce: npm/cli#6301.

@lpatiny lpatiny merged commit f36ab94 into main Aug 25, 2023
3 of 4 checks passed
@Xstoudi Xstoudi deleted the 55-use-infopanel branch August 25, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stropitek stropitek stropitek approved these changes

@lpatiny lpatiny lpatiny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use InfoPanel
5 participants
@wadjih-bencheikh18 @stropitek @Xstoudi @targos @lpatiny