Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EBS CSI Driver #2677

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

cosimomeli
Copy link
Contributor

@cosimomeli cosimomeli commented Jun 27, 2024

Add support for the recent EBS CSI Driver using the CSI field in the PVC to set the provisioner and the volume-id.
I'm keeping the retro compatibility with the old field.

@FxKu FxKu added this to the 1.14.0 milestone Jul 23, 2024
@FxKu FxKu added the minor label Aug 23, 2024
.gitignore Show resolved Hide resolved
@FxKu
Copy link
Member

FxKu commented Nov 6, 2024

I see that you created unit test into their own file and not in volume_test.go. This is fine for me. That file is already big enough.
Edit: Thanks for adding ebs_test.go because we do have ebs.go, too. 😃

But can you check why some of the tests are failing now with Unexpected call to *mocks.MockVolumeResizer.GetProviderVolumeID ...?

Edit 2: Found the reason (see my comment on volumes.go change). Please extend the unit test in volumes_test.go 🙏

@cosimomeli
Copy link
Contributor Author

The e2e tests passed locally. Is there a known flakiness?

@FxKu
Copy link
Member

FxKu commented Nov 11, 2024

👍

1 similar comment
@idanovinda
Copy link
Member

👍

@FxKu FxKu merged commit eef4950 into zalando:master Dec 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants