Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
as discussed in #169,I tried to add multiline support for legend items with long names. I used
tspan
as discussed and some dynamic height calculations (based on the bounding box (getBBox
) +getComputedTextLength
).It works as expected. The items lines are aligned after the legend number.
There is still room for improvement, because we should be able to calculate the entire structure of the legends dynamically. Anyway for now, if a legend list of items is too long we should play with the parameters I added the previous PRs to fix the offset (in particular the legends offsets).
Attached you can find some example:
I tested it carefully, but please do all the checks that you want/need on your side, and let me know if this PR makes sense and can be useful (like the previous one).
lastminute-tech-radar-example-video-720.mov
lastminute-tech-radar-example-code.zip