Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimallog #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add minimallog #16

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8deecb8
Do not crash on socket errors
matthid Feb 22, 2019
69c7573
Add an option to disable verbose error logs
matthid Feb 22, 2019
c398f7b
Fix error & warning
matthid May 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions src/devTools.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,17 @@ function handleMessages(message) {
});
}

function watch() {
function watch(options) {
if (channel) return;
socket.emit('login', 'master', (err, channelName) => {
if (err) { console.log(err); return; }
if (err) {
if (options.minimalLog) {
console.warn('removedev-socket, "login" was cancelled.');
} else {
console.warn('removedev-socket, "login" was cancelled.', err);
}
return;
}
channel = socket.subscribe(channelName);
channel.watch(handleMessages);
socket.on(channelName, handleMessages);
Expand All @@ -47,7 +54,14 @@ function connectToServer(options) {
};
} else socketOptions = defaultSocketOptions;
socket = socketCluster.create(socketOptions);
watch();
socket.on('error', err => {
if (options.minimalLog) {
console.warn('Error in removedev-socket');
} else {
console.warn('Error in removedev-socket', err);
}
});
watch(options);
}

export function start(options) {
Expand Down