Make the polling interval configurable. #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manoranjith
force-pushed
the
mano/configurable-polling
branch
from
7ff32f3 to
9b76b7c
Compare
manoranjith
force-pushed
the
mano/configurable-polling
branch
from
9b76b7c to
80390b1
Compare
manoranjith
force-pushed
the
mano/configurable-polling
branch
from
225fe2f to
ea0f02b
Compare
fd0r
reviewed
Dec 4, 2024
fd0r
approved these changes
Dec 4, 2024
|
Don't forget to follow conventional commit when adding this new config 😉 (aka breaking change) |
immortal-tofu
requested changes
Dec 5, 2024
|
The link is fixed. |
|
@fd0r Thanks for highlighting this could be a breaking change. I guess, i can make this a more soft change by adding a default value for The other config already has a default. Both values fallback to default, if not configured. I guess, this makes it not a breaking change ??? |
- Previously, the value was hardcoded to 5000ms. This could lead to long wait between processing jobs and hence a delay in result being available in the coprocessor db. - Now, make this interval configurable via command line argument. Can be fine tuned as per needed performance.
- Currently, this value is hardcoded to 10s. This could be too long, leading to artificial delay in the ciphertext being available in the coprocessor db. - Now, make it configurable via environment variable.
manoranjith
force-pushed
the
mano/configurable-polling
branch
from
de9d400 to
59ef973
Compare
dartdart26
reviewed
Dec 5, 2024
There was a problem hiding this comment.
Looks good! I just asked @goshawk-3 to check the select! statement as we discussed it, but maybe he got deeper on that.
This versioning scheme is more aligned with fhevm versioning scheme.
fd0r
approved these changes
Dec 5, 2024
dartdart26
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: make coprocessor sync interval configurable
Currently, this value is hardcoded to 10s. This could be too long,
leading to artificial delay in the ciphertext being available in the
coprocessor db.
Now, make it configurable via environment variable.
feat: make worker job polling interval config
Previously, the value was hardcoded to 5000ms. This could lead to long
wait between processing jobs and hence a delay in result being
available in the coprocessor db.
Now, make this interval configurable via command line argument. Can be
fine tuned as per needed performance.
chore: bump version to v0.1.2
Closes #169