Set server keys for each thread in Rayon pool #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dartdart26
approved these changes
Dec 5, 2024
| rayon_threads, | ||
| server_key.clone(), | ||
| )) | ||
| .unwrap(); |
There was a problem hiding this comment.
Nit: Maybe we can change that to expect()? I know it is not part of the PR, but just to use that as an excuse.
| @@ -4,10 +4,12 @@ on: | |||
| push: | |||
| branches: | |||
| - main | |||
| - temp-fix-coprocessor-crash | |||
There was a problem hiding this comment.
I guess these changes were just for testing on the CI? Could be removed before merging, right?
There was a problem hiding this comment.
yes exactly, let's revered them before merge
|
Discarded due to #176 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.