Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use config.service-name in coprocessor OTLP traces #184

Merged
merged 2 commits into from
Dec 12, 2024
Merged

feat: Use config.service-name in coprocessor OTLP traces #184

merged 2 commits into from
Dec 12, 2024

Conversation

goshawk-3
Copy link
Contributor

@goshawk-3 goshawk-3 commented Dec 12, 2024 •
edited
Loading

fixes #130

  • Add new CLI option --service-name
  • Set the service name in setting OTLP traces service name

traces

@goshawk-3 goshawk-3 force-pushed the georgi/add-otlp-name branch from 16126f8 to b97f0d7 Compare December 12, 2024 11:30
dartdart26
dartdart26 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@dartdart26 dartdart26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@goshawk-3 goshawk-3 merged commit 2670d71 into main Dec 12, 2024
5 checks passed
@goshawk-3 goshawk-3 deleted the georgi/add-otlp-name branch December 12, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dartdart26 dartdart26 dartdart26 approved these changes

@david-zk david-zk Awaiting requested review from david-zk

@immortal-tofu immortal-tofu Awaiting requested review from immortal-tofu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add service.name in coprocessor OTLP traces
2 participants
@goshawk-3 @dartdart26