Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: TFHEExecutor NatSpec #223

Merged
merged 2 commits into from
Dec 30, 2024
Merged

chore: TFHEExecutor NatSpec #223

merged 2 commits into from
Dec 30, 2024

Conversation

PacificYield
Copy link
Contributor

@PacificYield PacificYield commented Dec 30, 2024 •
edited
Loading

This PR introduces several changes:

  • use of custom errors
  • updates to Natspec function headers and other best practices
  • refactors for repeated code across functions

@PacificYield PacificYield self-assigned this Dec 30, 2024
@PacificYield PacificYield changed the title chore: TFHEExecutor NatSpec draft chore: TFHEExecutor NatSpec (WIP) Dec 30, 2024
@PacificYield PacificYield marked this pull request as ready for review December 30, 2024 14:13
@PacificYield PacificYield changed the title chore: TFHEExecutor NatSpec (WIP) chore: TFHEExecutor NatSpec Dec 30, 2024
@PacificYield PacificYield requested a review from jatZama December 30, 2024 14:13
@PacificYield PacificYield merged commit dbac17c into main Dec 30, 2024
3 checks passed
@PacificYield PacificYield deleted the natspec-tfhe-executor branch December 30, 2024 15:28
@PacificYield PacificYield mentioned this pull request Jan 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jatZama jatZama jatZama approved these changes

Assignees

@PacificYield PacificYield

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PacificYield @jatZama