Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fhe randomness implementation #25

Merged
merged 14 commits into from
Sep 16, 2024
Merged

Conversation

david-zk
Copy link
Contributor

  • refactor tests to only leave production functions in coprocessor
  • cargo fmt

@dartdart26 @antoniupop

+ refactor tests to only leave production functions in coprocessor
Copy link
Collaborator

@dartdart26 dartdart26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT, this PR uses ChaCha20 for randomness. But I think we want FHE randomness via: https://docs.zama.ai/tfhe-rs/fundamentals/encrypted-prf .

Do I miss something or we want to add it later? I think we want to add it now.

@david-zk
Copy link
Contributor Author

AFAICT, this PR uses ChaCha20 for randomness. But I think we want FHE randomness via: https://docs.zama.ai/tfhe-rs/fundamentals/encrypted-prf .

Do I miss something or we want to add it later? I think we want to add it now.

I copied from previous implementation, will change

@david-zk
Copy link
Contributor Author

@dartdart26 fixed a60733e

@david-zk david-zk force-pushed the davidk/fhe-rand-generation branch from 02e6b3b to 2014e41 Compare September 16, 2024 06:57
@david-zk david-zk merged commit 1e71941 into main Sep 16, 2024
1 of 2 checks passed
@david-zk david-zk deleted the davidk/fhe-rand-generation branch September 16, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants