Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare dockerfile for multiarch build #14

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Prepare dockerfile for multiarch build #14

merged 1 commit into from
Jul 26, 2023

Conversation

david-zk
Copy link
Collaborator

@david-zk david-zk force-pushed the multiarch_build branch 4 times, most recently from 7f18f98 to b7f9c19 Compare July 26, 2023 06:45
leventdem
leventdem approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@leventdem leventdem left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a discussion with tfhe-rs team, we have a single Dockerfile used to build/publish for arm64 and x86! In this version, we have disabled the hardware feature tfhe/arch-unix but have kept the seeder. The only drawback of removing the hardware feature is a less efficient key generation, but because we do not gen keys too much it should be fine!

+1

@david-zk david-zk merged commit 7fd4b41 into main Jul 26, 2023
1 check passed
@david-zk david-zk deleted the multiarch_build branch July 26, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leventdem leventdem leventdem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-zk @leventdem