Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: binary blob instead of hexstring fetching crs pubkey #118

Merged
merged 3 commits into from
Oct 22, 2024
Merged

chore: binary blob instead of hexstring fetching crs pubkey #118

merged 3 commits into from
Oct 22, 2024

Conversation

jatZama
Copy link
Member

@jatZama jatZama commented Oct 22, 2024

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 22, 2024
kc1212
kc1212 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@kc1212 kc1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jatZama
0.6.0-4
23a5e2f 
chore: typos in types

chore: typo

chore: ignore failing test due to non-safely serialized keys

chore: lowering jest threshold a little bit
@github-actions GitHub Actions
Copy link

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements
63.78% (-4.03% 🔻)
 280/439
🔴 Branches
54.64% (-1.48% 🔻)
 53/97
🔴 Functions
59.26% (-2.47% 🔻)
 48/81
🟡 Lines
63.59% (-2.81% 🔻)
 241/379
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🔴 sdk/network.ts
12% (-71.33% 🔻)
0% (-40% 🔻)
0% (-100% 🔻)
11.76% (-63.24% 🔻)

Test suite run success

13 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from 23a5e2f

@jatZama jatZama merged commit 3f4bdb1 into main Oct 22, 2024
5 checks passed
@immortal-tofu immortal-tofu deleted the safeDeserialize branch December 5, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kc1212 kc1212 kc1212 approved these changes

@PacificYield PacificYield Awaiting requested review from PacificYield

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jatZama @kc1212