feat(gpu): Implement fft128 in cuda backend #1823
Conversation
bbarbakadze
force-pushed
the
feat/gpu/fft128
branch
from
7f085c7 to
516ae67
Compare
| } | ||
| } | ||
|
|
||
| // fn test_product<Scalar: UnsignedTorus>() { |
There was a problem hiding this comment.
Can we get rid of all this comments?
There was a problem hiding this comment.
Do we want to keep all this comments?
There was a problem hiding this comment.
We could probably have the test using the functions you exposed for forward/inverse 128bit FFT @bbarbakadze, it would be good to have the same set of tests as the CPU.
|
there are many log files that should be erased |
bbarbakadze
force-pushed
the
feat/gpu/fft128
branch
from
85cff17 to
8e994b1
Compare
bbarbakadze
force-pushed
the
feat/gpu/fft128
branch
from
8e994b1 to
0c74110
Compare
| } | ||
| } | ||
|
|
||
| // fn test_product<Scalar: UnsignedTorus>() { |
There was a problem hiding this comment.
Do we want to keep all this comments?
| // println!("poly.len: {:?}", poly.len()); | ||
| // println!("rust poly"); | ||
| // for coefficient in poly.iter() { | ||
| // println!( |
There was a problem hiding this comment.
This could be removed too
| @@ -0,0 +1,17 @@ | |||
| #include <stdint.h> | |||
There was a problem hiding this comment.
This file should be named fft128.h maybe, and we could place it in a new folder include/fft, instead of include/pbs, wdyt?
| @@ -19,6 +19,7 @@ fn test_roundtrip<Scalar: UnsignedTorus>() { | |||
| let mut fourier_im0 = avec![0.0f64; fourier_size].into_boxed_slice(); | |||
| let mut fourier_im1 = avec![0.0f64; fourier_size].into_boxed_slice(); | |||
|
|
|||
| println!("sizeof_scalar: {:?}", Scalar::BITS); | |||
There was a problem hiding this comment.
This print can be removed
| @@ -62,6 +62,7 @@ fn main() { | |||
| "cuda/include/integer/integer.h", | |||
| "cuda/include/keyswitch.h", | |||
| "cuda/include/linear_algebra.h", | |||
| "cuda/include/pbs/fft.h", | |||
There was a problem hiding this comment.
The bindings.rs file should get updated in this PR, doesn't it get updated automatically when you build?
closes: please link all relevant issues
PR content/description
Check-list: