Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated zappa.async module #1326

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Remove deprecated zappa.async module #1326

merged 1 commit into from
Apr 10, 2024

Conversation

javulticat
Copy link
Member

@javulticat javulticat commented Apr 10, 2024

async has been a Python keyword since Py3.5, which we dropped support for several years ago, so the zappa.async module hasn't been usable in a long time. Removing it to avoid confusion and because the error-checking recently added in our new build process is preventing us from building a package containing a module that shares the name of a Python keyword (as it should, as such modules would fail to import).

@javulticat javulticat added python Related to Python support priority | P1 Priority: High CI/CD Improvements to the CI/CD pipeline labels Apr 10, 2024
@javulticat javulticat added this to the Zappa 0.59 milestone Apr 10, 2024
@javulticat javulticat self-assigned this Apr 10, 2024
@coveralls
Copy link

Coverage Status

coverage: 74.729% (+0.06%) from 74.668%
when pulling 1e0cc7b on jav/remove-async
into b272361 on master.

@javulticat javulticat merged commit 3b823d9 into master Apr 10, 2024
6 checks passed
@javulticat javulticat deleted the jav/remove-async branch April 10, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Improvements to the CI/CD pipeline priority | P1 Priority: High python Related to Python support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants