Kill all related process when exiting #2
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that on Windows the processes are not exited correctly.
The
execa
package create an Rscript process that launches thestart-shiny.R
script in main folder. This in turn creates an R process and another Rscript process, both related to the Shiny dashboard.When closing the main window the main process created by
execa
is terminated but the other two are left there as zombie processes and the Shiny dashboard can still be accessed if a web browser is pointed to the correct port.I propose a workaround I implemented for an upcoming app we are developing at my university that is based on this comment I found in a related issue on the execa GitHub.
The related pid of the process are kept in memory and manually terminated when exiting if they are still alive.