Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor compose e2e test to not depend on CLI output #3126

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

phillebaba
Copy link
Member

Description

This change removes any use of CLI output for compose e2e tests. This enables the refactoring of log output without breaking the e2e tests.

Related Issue

Relates to #2576
Relates to #2969

Checklist before merging

@phillebaba phillebaba requested review from a team as code owners October 22, 2024 17:08
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit ac9a75b
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6744b927950d3f0008b90d98

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@phillebaba phillebaba force-pushed the refactor/compose-test branch 2 times, most recently from f4afe74 to 27db1e6 Compare October 22, 2024 19:38
@phillebaba phillebaba force-pushed the refactor/compose-test branch from 27db1e6 to affddb3 Compare November 25, 2024 11:40
@phillebaba phillebaba force-pushed the refactor/compose-test branch from affddb3 to ac9a75b Compare November 25, 2024 17:51
Copy link
Contributor

@schristoff schristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor nit, but g2g

src/test/e2e/09_component_compose_test.go Show resolved Hide resolved
@phillebaba phillebaba added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 78cf2af Nov 26, 2024
26 checks passed
@phillebaba phillebaba deleted the refactor/compose-test branch November 26, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants