Update zarr 3 codec pipeline workflow #423
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpiannucci
commented
Feb 4, 2025
mpiannucci
temporarily deployed
to
test-release
GitHub Actions
Inactive
mpiannucci
temporarily deployed
to
test-release
GitHub Actions
Inactive
mpiannucci
temporarily deployed
to
test-release
GitHub Actions
Inactive
mpiannucci
temporarily deployed
to
test-release
GitHub Actions
Inactive
TomNicholas
added
zarr-python
| serializer = v3_codecs_to_serializer(codecs) | ||
| return ZarrV3Codecs( | ||
| filters=filters, compressors=compressors, serializer=serializer | ||
| ) |
There was a problem hiding this comment.
I'm curious if we replaced the ZArray class with zarr-python's ArrayV3Metadata would there be comparable functionality to parse out the filters, compressors and serializer, so those could be passed to zarr-python's create_array (same args as require_array)?
There was a problem hiding this comment.
I was going to do this with init_array but it requires a store path which i didnt want to deal with atm, but might be the right approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to handle codecs so that they match the zarr 3
create_arrayapidocs/releases.rstapi.rst