Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Zarr chunk manifest writing functionality #426

Merged
merged 7 commits into from
Feb 5, 2025

Conversation

norlandrhagen
Copy link
Collaborator

Aims to close #359. I included this in the zarr_reader PR, but since that's still a WIP, this separates it.

  • Closes #xxxx
  • Changes are documented in docs/releases.rst
  • New functions/methods are listed in api.rst

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.15%. Comparing base (49b0e9d) to head (6bf2988).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
- Coverage   89.23%   89.15%   -0.08%     
==========================================
  Files          31       28       -3     
  Lines        1839     1706     -133     
==========================================
- Hits         1641     1521     -120     
+ Misses        198      185      -13     
Files with missing lines Coverage Δ
virtualizarr/accessor.py 94.23% <ø> (-0.32%) ⬇️
virtualizarr/backend.py 97.01% <ø> (-0.09%) ⬇️
virtualizarr/readers/__init__.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@TomNicholas TomNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @norlandrhagen ! Just some minor nits then please merge!

FYI @abarciauskas-bgse

docs/releases.rst Outdated Show resolved Hide resolved
docs/releases.rst Outdated Show resolved Hide resolved
@TomNicholas
Copy link
Member

(docs failing because warnings become errors)

@norlandrhagen norlandrhagen merged commit 1782cee into main Feb 5, 2025
12 checks passed
@norlandrhagen norlandrhagen deleted the remove_zarr_manifest branch February 5, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove references to non-existent Zarr chunk manifest format
2 participants