-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Zarr chunk manifest writing functionality #426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norlandrhagen
temporarily deployed
to
test-release
February 5, 2025 17:49 — with
GitHub Actions
Inactive
norlandrhagen
temporarily deployed
to
test-release
February 5, 2025 17:52 — with
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
- Coverage 89.23% 89.15% -0.08%
==========================================
Files 31 28 -3
Lines 1839 1706 -133
==========================================
- Hits 1641 1521 -120
+ Misses 198 185 -13
|
TomNicholas
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @norlandrhagen ! Just some minor nits then please merge!
Co-authored-by: Tom Nicholas <[email protected]>
for more information, see https://pre-commit.ci
norlandrhagen
temporarily deployed
to
test-release
February 5, 2025 18:58 — with
GitHub Actions
Inactive
(docs failing because warnings become errors) |
norlandrhagen
temporarily deployed
to
test-release
February 5, 2025 19:12 — with
GitHub Actions
Inactive
norlandrhagen
temporarily deployed
to
test-release
February 5, 2025 20:19 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to close #359. I included this in the zarr_reader PR, but since that's still a WIP, this separates it.
docs/releases.rst
api.rst