Skip to content

Conversation

maxrjones
Copy link
Member

@maxrjones maxrjones commented Aug 11, 2025

This PR complements #766 by adding to_kerchunk support (whereas #766 added to_icechunk support). For a more robust long-term solution that would eliminate the need for separate metadata pipelines between kerchunk and icechunk, see issue #768.

@rsignell I tested your workflow works using this PR (see https://github.com/maxrjones/test-scripts/blob/main/test-virtualizarr-netcdf3/test-virtualizarr.py).

@rsignell
Copy link
Collaborator

Yep, this works for my use case!
image

Copy link
Member

@TomNicholas TomNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Let's just make sure this important bugfix is in the changelog.

Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.75%. Comparing base (9261537) to head (e52f226).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #769      +/-   ##
==========================================
+ Coverage   87.71%   87.75%   +0.03%     
==========================================
  Files          35       35              
  Lines        1872     1878       +6     
==========================================
+ Hits         1642     1648       +6     
  Misses        230      230              
Files with missing lines Coverage Δ
virtualizarr/utils.py 70.76% <100.00%> (+2.97%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TomNicholas TomNicholas added Kerchunk Relating to the kerchunk library / specification itself references generation Reading byte ranges from archival files labels Aug 14, 2025
@TomNicholas TomNicholas merged commit 7f1325d into zarr-developers:main Aug 14, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Kerchunk Relating to the kerchunk library / specification itself references generation Reading byte ranges from archival files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NetCDF3Parser workflow returning gibberish (while equivalent HDFParser workflow works fine)

3 participants