Clean up zarr.core.buffer API surface
#2641
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
normanrz
approved these changes
Jan 5, 2025
|
We should make sure we don't end up with two levels of underscores. My preference would be we do the full |
|
Yeah, doesn't need to block 3.0.0, and needs updating, but would be good to keep it open to remind me to update it at some point |
dstansby
added
the
needs release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the
zarr.core.bufferAPI, by makingzarr.core.buffer._coreprivate. Everything was already imported intozarr.core.buffer, but imports elsewhere in the library just needed changing.