Change VAPID expiration from 24h to 12h #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value of 24h is not a safe default value. Sometimes when you restart a server and the clock is wrong by a few seconds, it may result in notifications being rejected by Google Firebase. Note that 24h is the limit for Firebase, so even a small bias can cause issues. 12h is a better default because it ensures the notification delivery even if the clock is not perfect. 12h is the average between 24h (max) and 0 (min) and, given a random deviation in the clock, it maximizes the probability of successful notifications.
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value of 24h is not a safe default value.
Sometimes when you restart a server and the clock is wrong by a few seconds, it may result in notifications being rejected by Google Firebase.
Note that 24h is the limit for Firebase, so even a small bias can cause issues.
12h is a better default because it ensures the notification delivery even if the clock is not perfect.
12h is the average between 24h (max) and 0 (min) and, given a random deviation in the clock, it maximizes the probability of successful notifications.