Updated main.py to add an exclude array for users #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated main.py to add an exclude array for users so that community members can explicitly opt out.
zoidyzoidzoid
requested changes
Jun 17, 2019
| @@ -45,6 +48,8 @@ def process_message_event(client, event): | |||
| return | |||
| user = event['user'] | |||
| if any(hit in text.lower() for hit in HITS): | |||
| if any(excludeUser.lower() in user.lower() for excludeUser in EXCLUDE_USERS): | |||
There was a problem hiding this comment.
We could exit out even earlier in the function, since we don't need to check if they said something that triggers the bot's response, since it'll be faster and avoid the other work. I'd also suggest keeping the excluded users in a Python set instead of array, then we can just check if user.lower() in EXCLUDE_USERS.
| @@ -12,6 +12,9 @@ | |||
| from requests import post | |||
| from slackclient import SlackClient | |||
|
|
|||
| EXCLUDE_USERS = [ | |||
| 'UC2PXG134' | |||
There was a problem hiding this comment.
We should maybe put these in some sort of configuration file, since other folks are starting to use this bot on their own workspaces and potentially Slack user IDs could collide maybe? I also think including their username in a comment is useful, in case folks ask to get added/removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated main.py to add an exclude array for users so that community members can explicitly opt out as requested by the community.