Skip to content

Commit

Permalink
build(ci): Fix build metrics report (facebookincubator#11839)
Browse files Browse the repository at this point in the history
Summary:
Changes to finding GTest caused the build metrics job to fail as we don't have GTest in the image yet. See facebookincubator#11837

Pull Request resolved: facebookincubator#11839

Reviewed By: Yuhta

Differential Revision: D67347290

Pulled By: kgpai

fbshipit-source-id: a52f090cd6757b78204d4cbfd893834b7b314148
  • Loading branch information
assignUser authored and facebook-github-bot committed Dec 17, 2024
1 parent 2d2cdbd commit 6c73120
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions .github/workflows/build-metrics.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@ jobs:
defaults:
run:
shell: bash
env:
VELOX_DEPENDENCY_SOURCE: SYSTEM
simdjson_SOURCE: BUNDLED
xsimd_SOURCE: BUNDLED
steps:
- uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -121,7 +117,6 @@ jobs:
"/tmp/metrics"
upload-report:
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == 'facebookincubator/velox' }}
permissions:
contents: write
runs-on: ubuntu-latest
Expand Down Expand Up @@ -156,6 +151,13 @@ jobs:
cd scripts/bm-report
nix-shell --run "quarto render report.qmd"
- name: Upload Report Artifact
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
with:
name: report
path: scripts/bm-report/report.html
retention-days: 5

- name: Push Report
# The report only uses conbench data from 'main'
# so any data generated in a PR won't be included
Expand Down

0 comments on commit 6c73120

Please sign in to comment.