Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with latest rosys #121

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix compatibility with latest rosys #121

merged 1 commit into from
Jul 17, 2024

Conversation

rodja
Copy link
Member

@rodja rodja commented Jul 17, 2024

RoSys introduced a new abstract method in the CameraProvider (see zauberzeug/rosys#139). This PR adds it to our own.

@rodja rodja added the enhancement New feature or request label Jul 17, 2024
@rodja rodja added this to the 0.2.0 milestone Jul 17, 2024
@rodja rodja requested a review from pascalzauberzeug July 17, 2024 03:26
pascalzauberzeug
pascalzauberzeug approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@pascalzauberzeug pascalzauberzeug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on F13/RB36 and in simulation!

@pascalzauberzeug pascalzauberzeug merged commit 377b0a4 into main Jul 17, 2024
3 checks passed
@pascalzauberzeug pascalzauberzeug deleted the rosys-compatibility branch July 17, 2024 07:24
@LukasBaecker LukasBaecker mentioned this pull request Jul 17, 2024
Merged
4 tasks
@pascalzauberzeug pascalzauberzeug mentioned this pull request Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalzauberzeug pascalzauberzeug pascalzauberzeug approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rodja @pascalzauberzeug