Display weed locations as white dots in camera augmentation on real robot #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalzauberzeug
requested changes
Jul 17, 2024
There was a problem hiding this comment.
@rodja I changed the indentation in Commit 3351f17.
Is that correct?
And .projection() throws an error, because relative is a point and not a point3d
|
Yes, your indentation is correct. And I hopefully fixed the projection error... please try again @pascalzauberzeug. |
|
Seems like it doesnt use correct coordinates, the screen coordinates seem too small to me and the weeds are not shown in the image. Here is an example: |
|
Ok. Let's not spend more time on this. The work on zauberzeug/rosys#130 will begin shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces another place for the work around we use already in other parts of the code until zauberzeug/rosys#13 is implemented. It allows the weeds of the plant provider to be rendered as white dots in the CameraCard.