Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling Restoring Fields with Errors #243

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

LukasBaecker
Copy link
Contributor

Currently fields that have incomplete or faulty data which may happen to updates in the code base, the fields are getting deleted and will not be stored again. We want to prevent this. When data is loaded from the persistence missing values should be replaced to a default value and the user should be getting informed by a notification to recheck the field's data.

@LukasBaecker LukasBaecker added this to the 0.7.0 milestone Nov 29, 2024
@LukasBaecker LukasBaecker linked an issue Nov 29, 2024 that may be closed by this pull request
@LukasBaecker
Copy link
Contributor Author

Maybe we should also handle the data with non existing keys. Currently the restoring ignores this data. There should an option for the user to check out old data and maybe use them for a existing key.

@LukasBaecker LukasBaecker marked this pull request as ready for review December 2, 2024 09:41
Copy link
Contributor

@pascalzauberzeug pascalzauberzeug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@LukasBaecker LukasBaecker merged commit 4dc14c5 into main Dec 2, 2024
2 checks passed
@LukasBaecker LukasBaecker deleted the field_with_errors_handling branch December 2, 2024 09:42
@pascalzauberzeug pascalzauberzeug added bug Something isn't working enhancement New feature or request labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fields from Persistence Deleted
2 participants