Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve clear, remove and delete methods #1514

Merged
merged 9 commits into from
Aug 29, 2023

Conversation

falkoschindler
Copy link
Contributor

@falkoschindler falkoschindler commented Aug 29, 2023

This PR attempts to solve #1512.
It is currently work in progress, extending the tests to unveil two issues with the current implementation.

Open tasks:

  • let delete() correctly remove the element from its parent (test_delete_element)
  • correctly call _on_delete() for all children of a removed parent (test_remove_parent)
  • fix "RuntimeError: dictionary changed size during iteration"
  • extend the documentation about clear(), remove() and delete()

@falkoschindler falkoschindler self-assigned this Aug 29, 2023
@falkoschindler falkoschindler added the bug Something isn't working label Aug 29, 2023
@falkoschindler falkoschindler linked an issue Aug 29, 2023 that may be closed by this pull request
3 tasks
@falkoschindler falkoschindler added this to the 1.3.13 milestone Aug 29, 2023
@falkoschindler falkoschindler marked this pull request as ready for review August 29, 2023 11:23
@falkoschindler falkoschindler requested a review from rodja August 29, 2023 11:23
@falkoschindler falkoschindler merged commit 833b0cc into main Aug 29, 2023
@falkoschindler falkoschindler deleted the clear-remove-delete branch August 29, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

element.delete() does not correctly delete an element
1 participant