Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker cache in github actions #3918

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Fix docker cache in github actions #3918

merged 2 commits into from
Oct 25, 2024

Conversation

codingpaula
Copy link
Contributor

If this RoSys PR works, we fix the Docker cache here as well by not confining the cache to a commit.

@codingpaula codingpaula added the bug Something isn't working label Oct 24, 2024
@codingpaula codingpaula added this to the 2.5 milestone Oct 24, 2024
@codingpaula codingpaula self-assigned this Oct 24, 2024
@falkoschindler
Copy link
Contributor

@codingpaula It doesn't look like it worked... 😕
https://github.com/zauberzeug/rosys/actions/runs/11504940929

@codingpaula
Copy link
Contributor Author

This now worked in RoSys (see action). I implemented it here as well.

@codingpaula codingpaula marked this pull request as ready for review October 25, 2024 09:09
@falkoschindler falkoschindler merged commit 79f6d76 into main Oct 25, 2024
7 checks passed
@falkoschindler falkoschindler deleted the docker-cache-2 branch October 25, 2024 10:10
@falkoschindler falkoschindler added github_actions Pull requests that update GitHub Actions code and removed bug Something isn't working labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falkoschindler falkoschindler falkoschindler approved these changes

Assignees

@codingpaula codingpaula

Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.
2 participants
@codingpaula @falkoschindler