Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pre-commit and ruff #4052

Merged
merged 2 commits into from
Nov 30, 2024
Merged

update pre-commit and ruff #4052

merged 2 commits into from
Nov 30, 2024

Conversation

codingpaula
Copy link
Contributor

This PR updates ruff (0.3.5 to 0.8.1) and pre-commit. It also includes a few sorting and linting fixes that resulted from the ruff update.

@codingpaula codingpaula added the dependencies Pull requests that update a dependency file label Nov 30, 2024
@codingpaula codingpaula added this to the 2.8 milestone Nov 30, 2024
@codingpaula codingpaula self-assigned this Nov 30, 2024
falkoschindler
falkoschindler approved these changes Nov 30, 2024
View reviewed changes
Copy link
Contributor

@falkoschindler falkoschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I just noticed a missing comma (which was already missing before). Let's fix it once we're at it.

nicegui/json/__init__.py Outdated Show resolved Hide resolved
@falkoschindler falkoschindler merged commit 25a6334 into main Nov 30, 2024
8 checks passed
@falkoschindler falkoschindler deleted the pre-commit-update branch November 30, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falkoschindler falkoschindler falkoschindler approved these changes

Assignees

@codingpaula codingpaula

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.
2 participants
@codingpaula @falkoschindler