Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: classify mature mirnas #146

Open
wants to merge 55 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
7ed9971
docs: expand workflow description
deliaBlue Dec 22, 2023
ecc920c
docs: expand rule descriptions
deliaBlue Dec 24, 2023
b71d23b
Merge branch 'dev' into 126-docs-describe-workflow-rationale
deliaBlue Jan 2, 2024
cde4393
docs: fix typos
deliaBlue Jan 5, 2024
8ce1821
Merge branch 'dev' into 126-docs-describe-workflow-rationale
deliaBlue Jan 29, 2024
ce4e5b7
docs: update rules
deliaBlue Jan 29, 2024
4dfe8be
docs: update rules
deliaBlue Jan 30, 2024
b5c7200
Merge branch 'dev' into 126-docs-describe-workflow-rationale
deliaBlue Jan 30, 2024
9f8f99e
fix: set correct wildcard
deliaBlue Jan 30, 2024
1e345dd
docs: complete rules improvement
deliaBlue Jan 31, 2024
a4049b1
revert: undo refactoring
deliaBlue Feb 23, 2024
ed8d595
Merge branch 'dev' into 126-docs-describe-workflow-rationale
deliaBlue Feb 23, 2024
8f23697
Merge branch 'dev' into 126-docs-describe-workflow-rationale
uniqueg Mar 18, 2024
1eeb07a
docs: update main README
deliaBlue May 7, 2024
ada71c0
docs: update pipeline documentation
deliaBlue May 7, 2024
9030112
refactor: correct shift assessment
deliaBlue May 15, 2024
f37af52
docs: update pipeline documentation
deliaBlue May 24, 2024
dc5028e
docs: update README
deliaBlue May 24, 2024
bbb0727
fix typos2
deliaBlue Jun 10, 2024
c1bc82c
docs: extend workflow description
deliaBlue Jun 17, 2024
26d7813
refactor: account for new notation
deliaBlue Jul 28, 2024
077cf8b
Merge branch 'dev' into 126-docs-describe-workflow-rationale
deliaBlue Jul 31, 2024
9e3c639
Merge branch 'dev' into 126-docs-describe-workflow-rationale
deliaBlue Jul 31, 2024
cfba29e
Merge branch '126-docs-describe-workflow-rationale' of github.com:zav…
deliaBlue Jul 31, 2024
adc5833
merge dev branch
deliaBlue Jul 31, 2024
b57a5aa
docs: complete documentation
deliaBlue Aug 17, 2024
7741065
docs: complete documentation
deliaBlue Aug 17, 2024
694a537
refactor: adapt script to new name format
deliaBlue Aug 17, 2024
177c7ae
refactor: add read seq to isomiR tag
deliaBlue Aug 17, 2024
c578d9e
test: update unit test files
deliaBlue Aug 17, 2024
dc79f36
test: update unit tests
deliaBlue Aug 17, 2024
bbff4b5
Merge branch '126-docs-describe-workflow-rationale' into 143-fix-clas…
deliaBlue Aug 17, 2024
1439b5e
ci: update expected output
deliaBlue Aug 17, 2024
ad7afe9
docs: update isomiR name format
deliaBlue Aug 17, 2024
1d8c541
docs: update isomiR name format
deliaBlue Aug 17, 2024
1edc99b
test: adjust for new isomir name format
deliaBlue Aug 18, 2024
68fb655
test: adjust for isomir new name format
deliaBlue Aug 18, 2024
590b93d
revert: undo documetation branch merge
deliaBlue Aug 18, 2024
e1643ca
revert: undo documentation branch merge
deliaBlue Aug 18, 2024
032af37
ci: fix static code analysis
deliaBlue Aug 18, 2024
55712c7
ci: fix static code analysis
deliaBlue Aug 18, 2024
ce0d897
ci: fix static code analysis
deliaBlue Aug 18, 2024
fcc5ac4
ci: fix static code analysis
deliaBlue Aug 18, 2024
380cf76
Merge branch 'dev' into 143-fix-classify-correctly-mature-mirna
deliaBlue Aug 19, 2024
012645d
docs: add new isomiR notation
deliaBlue Aug 19, 2024
a516667
docs: add new isomiR notation
deliaBlue Aug 19, 2024
8173bf6
Merge branch 'dev' into 143-fix-classify-correctly-mature-mirna
deliaBlue Aug 31, 2024
4fd3f4b
Merge branch '143-fix-classify-correctly-mature-mirna' of github.com:…
deliaBlue Aug 31, 2024
ccfd504
test: remove duplicated file
deliaBlue Aug 31, 2024
85090da
refactor: add CLI argument
deliaBlue Jan 12, 2025
c40efce
refactor: modify tests
deliaBlue Jan 12, 2025
6a384eb
refactor: generalise script and add CLI
deliaBlue Jan 12, 2025
e2e9bf3
ci: upgrade miniconda to v3
deliaBlue Jan 12, 2025
3add762
ci: pin ubuntu version
deliaBlue Jan 12, 2025
fbf26bb
ci: set strict channel priority to true
deliaBlue Jan 12, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,11 @@ jobs:
uses: actions/checkout@v4

- name: Setup Conda/Mamba
uses: conda-incubator/setup-miniconda@v2
uses: conda-incubator/setup-miniconda@v3
with:
mamba-version: "*"
activate-environment: mirflowz
channel-priority: true
environment-file: environment.yml
auto-activate-base: false

Expand Down Expand Up @@ -64,10 +65,11 @@ jobs:
uses: actions/checkout@v4

- name: setup Conda/Mamba
uses: conda-incubator/setup-miniconda@v2
uses: conda-incubator/setup-miniconda@v3
with:
mamba-version: "*"
activate-environment: mirflowz
channel-priority: true
environment-file: environment.yml
auto-activate-base: false

Expand All @@ -90,7 +92,7 @@ jobs:


snakemake-integration-test:
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
defaults:
run:
shell: bash -l {0}
Expand All @@ -101,10 +103,11 @@ jobs:
uses: actions/checkout@v4

- name: setup Conda/Mamba
uses: conda-incubator/setup-miniconda@v2
uses: conda-incubator/setup-miniconda@v3
with:
mamba-version: "*"
activate-environment: mirflowz
channel-priority: true
environment-file: environment.yml
auto-activate-base: false

Expand Down Expand Up @@ -135,10 +138,11 @@ jobs:
uses: actions/checkout@v4

- name: setup Conda/Mamba
uses: conda-incubator/setup-miniconda@v2
uses: conda-incubator/setup-miniconda@v3
with:
mamba-version: "*"
activate-environment: mirflowz
channel-priority: true
environment-file: environment.yml
auto-activate-base: false

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ InDel or a mismatch on its sequence when compared to the canonical miRNA it
maps and intersects with.

_MIRFLOWZ_ employs an unambiguous notation to classify isomiRs using the
format `miRNA_name|5p-shift|3p-shift|CIGAR|MD`, where `5p-shift` and
format `miRNA_name|5p-shift|3p-shift|CIGAR|MD|read_seq`, where `5p-shift` and
`3p-shift` represent the differences between the annotated mature miRNA
start and end positions and those of the read alignment, respectively.

Expand Down
74 changes: 37 additions & 37 deletions pipeline_documentation.md
Original file line number Diff line number Diff line change
Expand Up @@ -1235,9 +1235,9 @@ with a [**custom script**][custom-script-iso-tag].
> extended ones. Each alignment gets an extra tag (`YW:Z`) with either the
> (iso)miR(s) it is considered to really intersect with or an empty string
> otherwise. The format of the intersecting mature miRNA species is
> `miRNA_name|5p-shift|3p-shift|CIGAR|MD`, where `5p-shift` and `3p-shift` are
> the difference between the miRNA start and end coordinates and the
> alignment's ones respectively.
> `miRNA_name|5p-shift|3p-shift|CIGAR|MD|read_name`, where `5p-shift` and
> `3p-shift` are the difference between the miRNA start and end coordinates and
> the alignment's ones respectively.

- **Input**
- Alignments file, filtered (`.sam`); from
Expand All @@ -1261,7 +1261,7 @@ IN miRNA annotations:
IN SAM record:
1-1_1 0 19 44377 255 22M * 0 0 CTACAAAGGGAAGCACTTTCTC * MD:Z:22 NH:i:1 NM:i:0
NEW TAG:
YW:Z:hsa-miR-524-5p|0|0|22M|22
YW:Z:hsa-miR-524-5p|0|0|22M|22|CTACAAAGGGAAGCACTTTCTC


Example 2 | Intersecting an isomiR (no shifts)
Expand All @@ -1271,7 +1271,7 @@ IN miRNA annotations:
IN SAM record:
1-1_1 0 19 44377 1 11M3I11M * 0 0 CTACAAAGGGAGGTAGCACTTTCTC * HI:i:0 MD:Z:22 NH:i:1 NM:i:3
NEW TAG:
YW:Z:hsa-miR-524-5p|0|0|11M3I11M|22
YW:Z:hsa-miR-524-5p|0|0|11M3I11M|22|CTACAAAGGGAGGTAGCACTTTCTC


Example 3 | Intersecting an isomiR (no InDels nor mismatches)
Expand All @@ -1281,7 +1281,7 @@ IN miRNA annotations:
IN SAM record:
1-1_1 0 19 5338 255 21M * 0 0 TCAAAACTGAGGGGCATTTTC * MD:Z:21 NH:i:1 NM:i:0
NEW TAG:
YW:Z:hsa-miR-1323|0|-1|21M|21
YW:Z:hsa-miR-1323|0|-1|21M|21|TCAAAACTGAGGGGCATTTTC


Example 4 | Not intersecting an (iso)miR
Expand Down Expand Up @@ -1355,20 +1355,20 @@ Data:
Contribution: 4/2 = 2

miRNA species:
Tag name: hsa-miR-520b-3p|0|0|21M|21
Tag name: hsa-miR-520b-3p|0|0|21M|21|AAAGTGCTTCCTTTTAGAGGG
Type: Canonical
Table name: hsa-miR-520b-3p
Total count: 2

Tag name: hsa-miR-520c-3p|0|-1|21M|21
Tag name: hsa-miR-520c-3p|0|-1|21M|21|AAAGTGCTTCCTTTTAGAGGG
Type: isomiR
Table name: hsa-miR-520c-3p|0|-1|21M|21
Table name: hsa-miR-520c-3p|0|-1|21M|21|AAAGTGCTTCCTTTTAGAGGG
Total count: 2

OUT table:
ID lib_name
hsa-miR-520b-3p 2
hsa-miR-520c-3p|0|-1|21M|21 2
ID lib_name
hsa-miR-520b-3p 2
hsa-miR-520c-3p|0|-1|21M|21|AAAGTGCTTCCTTTTAGAGGG 2


Example 2 | Different isomiRs
Expand All @@ -1386,26 +1386,26 @@ Data:
Contribution: 1/3 = 0.33

miRNA species:
Tag name: hsa-miR-526b-3p|1|-1|20M|20
Tag name: hsa-miR-526b-3p|1|-1|20M|20|AAAGTGCTTCCTTTTAGAGG
Type: isomiR
Table name: hsa-miR-526b-3p|1|-1|20M|20
Table name: hsa-miR-526b-3p|1|-1|20M|20|AAAGTGCTTCCTTTTAGAGG
Total count: 0.33

Tag name: hsa-miR-520b-3p|0|-1|20M|20
Tag name: hsa-miR-520b-3p|0|-1|20M|20|AAAGTGCTTCCTTTTAGAGG
Type: isomiR
Table name: hsa-miR-520b-3p|0|-1|20M|20
Table name: hsa-miR-520b-3p|0|-1|20M|20|AAAGTGCTTCCTTTTAGAGG
Total count: 0.33

Tag name: hsa-miR-520c-3p|0|-2|20M|20
Tag name: hsa-miR-520c-3p|0|-2|20M|20|AAAGTGCTTCCTTTTAGAGG
Type: isomiR
Table name: hsa-miR-520c-3p|0|-2|20M|20
Table name: hsa-miR-520c-3p|0|-2|20M|20|AAAGTGCTTCCTTTTAGAGG
Total count: 0.33

OUT table:
ID lib_name
hsa-miR-520b-3p|0|-1|20M|20 0.33
hsa-miR-520c-3p|0|-2|20M|20 0.33
hsa-miR-526b-3p|1|-1|20M|20 0.33
ID lib_name
hsa-miR-520b-3p|0|-1|20M|20|AAAGTGCTTCCTTTTAGAGG 0.33
hsa-miR-520c-3p|0|-2|20M|20|AAAGTGCTTCCTTTTAGAGG 0.33
hsa-miR-526b-3p|1|-1|20M|20|AAAGTGCTTCCTTTTAGAGG 0.33
```


Expand Down Expand Up @@ -1506,27 +1506,27 @@ Merge all the tables from the different libraries into a single one with a

```console
IN library 1
ID lib_1
hsa-miR-524-5p 1
hsa-miR-524-5p|0|0|22M|9G12 1
hsa-miR-524-5p|0|0|22M|9G9C2 1
ID lib_1
hsa-miR-524-5p 1
hsa-miR-524-5p|0|0|22M|9G12|CTACAAAGGTAAGCACTTTCTC 1
hsa-miR-524-5p|0|0|22M|9G9C2|CTACAAAGGTAAGCACTTTATC 1

IN library 2
ID lib_2
hsa-miR-524-5p 1
hsa-miR-1283 1
hsa-miR-1283|-1|-2|21M|21 1
ID lib_2
hsa-miR-524-5p 1
hsa-miR-1283 1
hsa-miR-498-3p|0|0|23M|8T14|AAAGCACCACCAGAGCTTGAAGC 1

IN library 3
ID lib_3
ID lib_3

OUT table
ID lib_1 lib_2 lib_3
hsa-miR-524-5p 1 1 NA
hsa-miR-524-5p|0|0|22M|9G12 1 NA NA
hsa-miR-524-5p|0|0|22M|9G9C2 1 NA NA
hsa-miR-1283 NA 1 NA
hsa-miR-1283|-1|-2|21M|21 NA 1 NA
ID lib_1 lib_2 lib_3
hsa-miR-524-5p 1 1 NA
hsa-miR-524-5p|0|0|22M|9G12|CTACAAAGGTAAGCACTTTCTC 1 NA NA
hsa-miR-524-5p|0|0|22M|9G9C2|CTACAAAGGTAAGCACTTTATC 1 NA NA
hsa-miR-1283 NA 1 NA
hsa-miR-498-3p|0|0|23M|8T14|AAAGCACCACCAGAGCTTGAAGC NA 1 NA
```


Expand Down
Loading
Loading