Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transcript sampler #15

Merged
merged 13 commits into from
Oct 20, 2023
Merged

fix: transcript sampler #15

merged 13 commits into from
Oct 20, 2023

Conversation

balajtimate
Copy link
Collaborator

Description

  • Refactored transcript-sampler to output the representative transcript from the given gtf annotation file, and return the Poisson-sampled number of transcripts, based on the given expression csv as well as the representative transcript for each gene.
  • Updated test files for transcript-sampler

Fixes #14

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Please carefully read these items and tick them off if the statements are true
or do not apply.

  • I have performed a self-review of my own code
  • My code follows the existing coding style, lints and generates no new
    warnings
  • I have added type annotations to all function/method signatures, and I
    have added type annotations for any local variables that are non-trivial,
    potentially ambiguous or might otherwise benefit from explicit typing.
  • I have commented my code in hard-to-understand areas
  • I have added ["Google-style docstrings"] to all new modules, classes,
    methods/functions or updated previously existing ones
  • I have added tests that prove my fix is effective or that my feature
    works
  • New and existing unit tests pass locally with my changes and I have not
    reduced the code coverage relative to the previous state
  • I have updated any sections of the app's documentation that are affected
    by the proposed changes

If for some reason you are unable to tick off all boxes, please leave a
comment explaining the issue you are facing so that we can work on it
together.

@balajtimate balajtimate merged commit e246915 into dev Oct 20, 2023
2 of 6 checks passed
@balajtimate balajtimate deleted the fix_structure_generator branch October 20, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: transcript sampler outputs non-matching representative transcripts
1 participant