Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add detailed decode for separed memories #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Haraguroicha
Copy link
Contributor

There are only accept the first meet of memory type and speed, but there may have two or more different kind of memories installed into system at same time but there can not describe it.

So I add a Memories property to store the memory detailed information (I only pick some general use fields to decode)

@zcalusic
Copy link
Owner

zcalusic commented May 2, 2019

Hello @Haraguroicha and thanks for your contribution!

Still not much time to work on this properly, but at least I gave it a quick compile to see how it looks.

But, tested on 2 different machines, I just get panic: runtime error: slice bounds out of range

So, it will need more work and testing before I could merge it.

@Haraguroicha
Copy link
Contributor Author

Hi @zcalusic , thank for your response, I think I will test on more machine as I can and push addition patch to this PR.

@Haraguroicha
Copy link
Contributor Author

Hi @zcalusic, I think I can't reproduce the panic: runtime error: slice bounds out of range in Dell OptiPlex 7060 and ThinkPad X1 Carbon, it might the DMI data looks different between yours hardware environment and mine, could you please paste the trace log for this PR, and I will push addition patch to prevent it happened again, thanks.

@azvs
Copy link

azvs commented Jul 9, 2019

Hi @zcalusic, I think I can't reproduce the panic: runtime error: slice bounds out of range in Dell OptiPlex 7060 and ThinkPad X1 Carbon, it might the DMI data looks different between yours hardware environment and mine, could you please paste the trace log for this PR, and I will push addition patch to prevent it happened again, thanks.

try virtual machine;
my virtual machine also has this issue

Hi @zcalusic, I think I can't reproduce the panic: runtime error: slice bounds out of range in Dell OptiPlex 7060 and ThinkPad X1 Carbon, it might the DMI data looks different between yours hardware environment and mine, could you please paste the trace log for this PR, and I will push addition patch to prevent it happened again, thanks.

try virtual machine;
my virtual machine also has this issue

@Haraguroicha Haraguroicha force-pushed the detailed-decode-separed-memories branch from 0184277 to ee001ba Compare November 28, 2019 09:09
@zcalusic zcalusic force-pushed the master branch 8 times, most recently from d086206 to 5776642 Compare May 28, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants