Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor sapling::tree::Node #1058

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Refactor sapling::tree::Node #1058

merged 2 commits into from
Dec 5, 2023

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Dec 4, 2023

No description provided.

str4d added 2 commits December 4, 2023 20:24
@str4d
zcash_primitives: Refactor sapling::tree::Node around jubjub::Base
8acc037
@str4d
zcash_primitives: Move Sapling HashSer impl into merkle_tree module
906e203 
The `HashSer` trait will remain in `zcash_primitives` while the Sapling
type it is implemented for moves to `sapling-crypto`.

Part of #1044.
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (acf1462) 70.77% compared to head (906e203) 70.80%.

Files Patch % Lines
zcash_primitives/src/merkle_tree.rs 66.66% 3 Missing ⚠️
zcash_primitives/src/sapling/tree.rs 82.35% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1058      +/-   ##
==========================================
+ Coverage   70.77%   70.80%   +0.02%     
==========================================
  Files         138      138              
  Lines       13709    13725      +16     
==========================================
+ Hits         9703     9718      +15     
- Misses       4006     4007       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nuttycom
nuttycom approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 906e203

@str4d str4d merged commit fedc9af into main Dec 5, 2023
@str4d str4d deleted the 1044-sapling-tree-leaf-refactor branch December 5, 2023 12:29
@str4d str4d added the C-tech-debt Category: Technical debt that needs to be paid off label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuttycom nuttycom nuttycom approved these changes

Assignees
No one assigned
Labels
C-tech-debt Category: Technical debt that needs to be paid off
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@str4d @nuttycom