error: using `clone` on type `note::RandomSeed` which implements the `Copy` trait --> src/builder.rs:298:25 | 298 | rseed: Some(self.note.rseed().clone()), | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.note.rseed()` | = note: `-D clippy::clone-on-copy` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

error: using `clone` on type `note::RandomSeed` which implements the `Copy` trait --> src/builder.rs:388:25 | 388 | rseed: Some(note.rseed().clone()), | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*note.rseed()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

error: this function has too many arguments (13/7) --> src/pczt/parse.rs:97:5 | 97 | / pub fn parse( 98 | | nullifier: [u8; 32], 99 | | rk: [u8; 32], 100 | | spend_auth_sig: Option<[u8; 64]>, ... | 110 | | proprietary: BTreeMap<String, Vec<u8>>, 111 | | ) -> Result<Self, ParseError> { | |_________________________________^ | = note: `-D clippy::too-many-arguments` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

error: this function has too many arguments (11/7) --> src/pczt/parse.rs:205:5 | 205 | / pub fn parse( 206 | | spend_nullifier: Nullifier, 207 | | cmx: [u8; 32], 208 | | ephemeral_key: [u8; 32], ... | 216 | | proprietary: BTreeMap<String, Vec<u8>>, 217 | | ) -> Result<Self, ParseError> { | |_________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

error: useless conversion to the same type: `primitives::redpallas::Signature<reddsa::orchard::SpendAuth>` --> src/pczt/tx_extractor.rs:33:20 | 33 | Ok(redpallas::Signature::from( | ____________________^ 34 | | action 35 | | .spend 36 | | .spend_auth_sig 37 | | .clone() 38 | | .ok_or(TxExtractorError::MissingSpendAuthSig)?, 39 | | )) | |_________________^ | = note: `-D clippy::useless-conversion` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `redpallas::Signature::from()` | 33 ~ Ok((action 34 + .spend 35 + .spend_auth_sig 36 + .clone() 37 ~ .ok_or(TxExtractorError::MissingSpendAuthSig)?)) |

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/pczt/tx_extractor.rs:92:45 | 92 | let authorization = bundle_auth(&self)?; | ^^^^^ help: change this to: `self` | = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

error: you are deriving `PartialEq` and can implement `Eq` --> src/pczt.rs:258:26 | 258 | #[derive(Debug, Getters, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = note: `-D clippy::derive-partial-eq-without-eq` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq