usage of `Iterator::fold` on a type that implements `Try`

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

doc list item without indentation

doc list item without indentation

doc list item without indentation

doc list item without indentation

the following explicit lifetimes could be elided: 'a

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

the following explicit lifetimes could be elided: 'a

the following explicit lifetimes could be elided: 'a

usage of `Iterator::fold` on a type that implements `Try`

usage of `Iterator::fold` on a type that implements `Try`

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

warning: usage of `Iterator::fold` on a type that implements `Try` --> src/builder.rs:642:14 | 642 | .fold(Some(ValueSum::zero()), |acc, note_value| acc? + note_value) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, note_value| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `#[warn(clippy::manual_try_fold)]` on by default

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> src/builder.rs:816:18 | 816 | .zip(indexed_outputs.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `indexed_outputs` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:589:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

warning: usage of `Iterator::fold` on a type that implements `Try` --> src/builder.rs:839:10 | 839 | .fold(Some(ValueSum::zero()), |acc, action| { | __________^ 840 | | acc? + action.value_sum() 841 | | }) | |__________^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, action| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

warning: doc list item without indentation --> src/bundle/commitments.rs:19:5 | 19 | /// with ZCASH_ORCHARD_ACTIONS_COMPACT_HASH_PERSONALIZATION | ^^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 19 | /// with ZCASH_ORCHARD_ACTIONS_COMPACT_HASH_PERSONALIZATION | +

warning: doc list item without indentation --> src/bundle/commitments.rs:21:5 | 21 | /// with ZCASH_ORCHARD_ACTIONS_MEMOS_HASH_PERSONALIZATION | ^^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 21 | /// with ZCASH_ORCHARD_ACTIONS_MEMOS_HASH_PERSONALIZATION | +

warning: doc list item without indentation --> src/bundle/commitments.rs:23:5 | 23 | /// with ZCASH_ORCHARD_ACTIONS_NONCOMPACT_HASH_PERSONALIZATION | ^^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 23 | /// with ZCASH_ORCHARD_ACTIONS_NONCOMPACT_HASH_PERSONALIZATION | +

warning: doc list item without indentation --> src/bundle/commitments.rs:24:5 | 24 | /// as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244] | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 24 | /// as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244] | +++

warning: the following explicit lifetimes could be elided: 'a --> src/bundle.rs:181:14 | 181 | impl<'a, T: fmt::Debug> fmt::Debug for Actions<'a, T> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 181 - impl<'a, T: fmt::Debug> fmt::Debug for Actions<'a, T> { 181 + impl<T: fmt::Debug> fmt::Debug for Actions<'_, T> { |

warning: large array defined as const --> src/constants/fixed_bases/commit_ivk_r.rs:30:1 | 30 | pub const U: [[[u8; 32]; super::H]; super::NUM_WINDOWS] = [ | ^ ----- help: make this a static item: `static` | _| | | 31 | | [ 32 | | [ 33 | | 38, 43, 235, 53, 200, 116, 153, 194, 47, 92, 18, 54, 194, 221, 170, 155, 205, 143, 92, ... | 2920 | | ], 2921 | | ]; | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_const_arrays = note: `#[warn(clippy::large_const_arrays)]` on by default