Add CI workflow for verifying no_std compatibility. #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
approved these changes
Dec 19, 2024
| @@ -11,6 +11,7 @@ and this project adheres to Rust's notion of | |||
| - `orchard::pczt::Zip32Derivation::extract_account_index` | |||
|
|
|||
| ### Changed | |||
| - MSRV is now 1.66 | |||
There was a problem hiding this comment.
What requires or motivates the MSRV bump in orchard? Is it just "parity with sapling-crypto"? (And what was the motivation there?)
There was a problem hiding this comment.
This is the easiest workaround for the constant_time_eq MSRV breaking bump; I figure that 1.66 is old enough now that it should basically be fine to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.