Skip to content

Release orchard version 0.10.1 #3310

Release orchard version 0.10.1

Release orchard version 0.10.1 #3310

GitHub Actions / Clippy Result (stable) succeeded Dec 17, 2024 in 16s

Clippy (Stable ~ Linux/x86_64)

Clippy was successful!

Details

Running cargo clippy took roughly ~16155ms to complete

  • Working Directory: repository directory

Annotations

Check warning on line 639 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L639

usage of `Iterator::fold` on a type that implements `Try`
Raw output
warning: usage of `Iterator::fold` on a type that implements `Try`
   --> src/builder.rs:639:14
    |
639 |             .fold(Some(ValueSum::zero()), |acc, note_value| acc? + note_value)
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, note_value| ...)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
    = note: `#[warn(clippy::manual_try_fold)]` on by default

Check warning on line 813 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L813

explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Raw output
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> src/builder.rs:813:18
    |
813 |             .zip(indexed_outputs.into_iter())
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `indexed_outputs`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:589:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `#[warn(clippy::useless_conversion)]` on by default

Check warning on line 19 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L19

doc list item without indentation
Raw output
warning: doc list item without indentation
  --> src/bundle/commitments.rs:19:5
   |
19 | ///   with ZCASH_ORCHARD_ACTIONS_COMPACT_HASH_PERSONALIZATION
   |     ^^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
   = note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
   |
19 | ///    with ZCASH_ORCHARD_ACTIONS_COMPACT_HASH_PERSONALIZATION
   |       +

Check warning on line 21 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L21

doc list item without indentation
Raw output
warning: doc list item without indentation
  --> src/bundle/commitments.rs:21:5
   |
21 | ///   with ZCASH_ORCHARD_ACTIONS_MEMOS_HASH_PERSONALIZATION
   |     ^^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
21 | ///    with ZCASH_ORCHARD_ACTIONS_MEMOS_HASH_PERSONALIZATION
   |       +

Check warning on line 23 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L23

doc list item without indentation
Raw output
warning: doc list item without indentation
  --> src/bundle/commitments.rs:23:5
   |
23 | ///   with ZCASH_ORCHARD_ACTIONS_NONCOMPACT_HASH_PERSONALIZATION
   |     ^^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
23 | ///    with ZCASH_ORCHARD_ACTIONS_NONCOMPACT_HASH_PERSONALIZATION
   |       +

Check warning on line 24 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L24

doc list item without indentation
Raw output
warning: doc list item without indentation
  --> src/bundle/commitments.rs:24:5
   |
24 | /// as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244]
   |     ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
24 | ///    as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244]
   |     +++

Check warning on line 179 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L179

the following explicit lifetimes could be elided: 'a
Raw output
warning: the following explicit lifetimes could be elided: 'a
   --> src/bundle.rs:179:14
    |
179 |         impl<'a, T: fmt::Debug> fmt::Debug for Actions<'a, T> {
    |              ^^                                        ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
    |
179 -         impl<'a, T: fmt::Debug> fmt::Debug for Actions<'a, T> {
179 +         impl<T: fmt::Debug> fmt::Debug for Actions<'_, T> {
    |

Check warning on line 252 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L252

explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Raw output
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> src/note_encryption.rs:252:18
    |
252 |             .zip(ephemeral_keys.into_iter())
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `ephemeral_keys`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/202008a1b8de96d2e5b6bc02d379db03a877d34d/library/core/src/iter/traits/iterator.rs:589:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 20 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L20

the following explicit lifetimes could be elided: 'a
Raw output
warning: the following explicit lifetimes could be elided: 'a
  --> src/pczt/updater.rs:20:6
   |
20 | impl<'a> Updater<'a> {
   |      ^^          ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
20 - impl<'a> Updater<'a> {
20 + impl Updater<'_> {
   |

Check warning on line 45 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L45

the following explicit lifetimes could be elided: 'a
Raw output
warning: the following explicit lifetimes could be elided: 'a
  --> src/pczt/updater.rs:45:6
   |
45 | impl<'a> ActionUpdater<'a> {
   |      ^^                ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
45 - impl<'a> ActionUpdater<'a> {
45 + impl ActionUpdater<'_> {
   |

Check warning on line 216 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L216

usage of `Iterator::fold` on a type that implements `Try`
Raw output
warning: usage of `Iterator::fold` on a type that implements `Try`
   --> src/value.rs:216:14
    |
216 |         iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + *v).ok_or(OverflowError))
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

Check warning on line 222 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L222

usage of `Iterator::fold` on a type that implements `Try`
Raw output
warning: usage of `Iterator::fold` on a type that implements `Try`
   --> src/value.rs:222:14
    |
222 |         iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + v).ok_or(OverflowError))
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold