Skip to content

Crate maintenance

Crate maintenance #8

Triggered via pull request December 11, 2023 18:41
Status Failure
Total duration 4m 54s
Artifacts

ci.yml

on: pull_request
Bitrot check
50s
Bitrot check
Clippy (MSRV)
30s
Clippy (MSRV)
Intra-doc links
38s
Intra-doc links
Rustfmt
9s
Rustfmt
Matrix: build-latest
Matrix: build-nodefault
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

13 errors
Latest build on ubuntu-latest
Process completed with exit code 1.
Latest build on macOS-latest
The operation was canceled.
Latest build on windows-latest
The operation was canceled.
use of `default` to create a unit struct: src/lib.rs#L502
error: use of `default` to create a unit struct --> src/builder.rs:502:42 | 502 | _proof_state: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-D clippy::default-constructed-unit-structs` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::default_constructed_unit_structs)]`
use of `default` to create a unit struct: src/lib.rs#L653
error: use of `default` to create a unit struct --> src/builder.rs:653:38 | 653 | _proof_state: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: src/lib.rs#L754
error: use of `default` to create a unit struct --> src/builder.rs:754:42 | 754 | _proof_state: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: src/lib.rs#L299
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> src/note_encryption.rs:299:18 | 299 | .zip(ephemeral_keys.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `ephemeral_keys` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: src/lib.rs#L312
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> src/note_encryption.rs:312:18 | 312 | .zip(ephemeral_keys.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `ephemeral_keys` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: src/lib.rs#L41
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> src/pedersen_hash.rs:41:16 | 41 | .chain(bits.into_iter()); | ^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `bits` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/iter/traits/iterator.rs:523:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
usage of `Iterator::fold` on a type that implements `Try`: src/lib.rs#L63
error: usage of `Iterator::fold` on a type that implements `Try` --> src/value/sums.rs:63:14 | 63 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + *v).ok_or(OverflowError)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `-D clippy::manual-try-fold` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::manual_try_fold)]`
usage of `Iterator::fold` on a type that implements `Try`: src/lib.rs#L69
error: usage of `Iterator::fold` on a type that implements `Try` --> src/value/sums.rs:69:14 | 69 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + v).ok_or(OverflowError)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
aborting due to 8 previous errors
error: aborting due to 8 previous errors
Intra-doc links
Process completed with exit code 101.