Add a changelog #110
Merged
Add a changelog #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted from the `zcash_primitives` changelog. We only include changes relative to the `zcash_primitives::sapling` module as of 0.13.0; prior changes never corresponded to published `sapling-crypto` releases. Source: https://github.com/zcash/librustzcash Rev: zcash/librustzcash@6acc64e
str4d
force-pushed
the
changelog-from-refactor
branch
from
98ddd58
to
146bc59
Compare
nuttycom
reviewed
Dec 12, 2023
| - `SaplingBuilder::add_spend` now takes `extsk` by reference. Also, it no | ||
| longer takes a `diversifier` argument as the diversifier may be obtained | ||
| from the note. | ||
| - `SaplingBuilder::add_output` now takes an `Option<[u8; 512]>` memo instead |
There was a problem hiding this comment.
I wonder whether it would actually be more correct to take [u8; 512] rather than an Optional value; if we're taking the Option here, it means that we're enforcing the Zcash network 0xf6 convention on all users.
There was a problem hiding this comment.
The same comment applies to the Orchard builder.
nuttycom
requested changes
Dec 12, 2023
nuttycom
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from the
zcash_primitiveschangelog. We only include changes relative to thezcash_primitives::saplingmodule as of 0.13.0; prior changes never corresponded to publishedsapling-cryptoreleases.Paired with zcash/librustzcash#1068.