-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZIP 400: Update wallet schema #968
base: main
Are you sure you want to change the base?
Conversation
zips/zip-0400.rst
Outdated
|
||
"acc*", "Account data", "1. ``string strAccount``", "1. ``CAccount account``" | ||
"acentry*", "Track internal transfers between accounts in the same wallet", "1. ``string strAccount`` | ||
"3..4", "acc*", "Account data", "1. ``string strAccount``", "1. ``CAccount account``" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the end version is less than 6:
- Check this is actually correct.
- If it is, describe how later versions handle/migrate the key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like both acc
and acentry
, which were part of the 'account' API, were disabled since the Zcash launch, and removed in v4.5.0: https://github.com/zcash/zcash/releases/tag/v4.5.0.
Here is also the Bitcoin Core release it references: https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-0.17.0.md#label-and-account-apis-for-wallet.
Should we add the fact that both were deprecated/disabled, and that they have no replacement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK with comments.
Co-authored-by: Daira-Emma Hopwood <[email protected]>
…r `chdseed` & `hdseed` and add instancing details.
Ref: #964. This PR updates the wallet schema to incorporate all changes across different
zcashd
versions.