Remove tests for em_mysql2 adapter #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that em-synchrony is no longer being updated and no longer works with recent versions of Active Record, causing the build to fail. This commit can be reverted when these em-synchrony issues are resolved.
sferik
force-pushed
the
remove-em-synchrony
branch
from
8447d6d to
fd6427c
Compare
|
There appear to be some legitimate build errors that may have been going undetected up to this point due to the |
Merged
|
Thanks for doing this @sferik, I've created PR #239 based on your work here since I needed to remove a few more things to rid activerecord-import of For future readers to this issue: this removes support the em-synchrony and mysql adapters. For |
|
This has been included in the 0.12.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that
em-synchronyis no longer being updated and no longer works with recent versions of Active Record, causing the build to fail. This commit can be reverted when theseem-synchronyissues are resolved.Please see this comment for additional rationale.