Add recursive import support for sqlite3 #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkowens
force-pushed
the
sqlite3_recursive
branch
from
1d25c94 to
97861ea
Compare
| end | ||
| end | ||
| end | ||
| end |
|
@jkowens, this looks good. It looks like AR 5.0 and AR 3.1 aren't happy. I'm less worried about 3.1 as we're going to deprecating that soon. Any thoughts on what's up with AR 5.0? |
jkowens
force-pushed
the
sqlite3_recursive
branch
from
97861ea to
5a40e69
Compare
|
Thanks @jkowens ! |
|
This is going out in the 0.14.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #247.
Sqlite doesn't support concurrent write operations, so it can be assumed all ids for a batch insert will be sequential.
This also extracts the recursive import tests out into a shared example so that they can be applied to other adapters. If all adapters eventually get this functionality, the specs could be moved into the main spec file.