-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Discord presence extension #1217
Add Discord presence extension #1217
Conversation
We require contributors to sign our Contributor License Agreement, and we don't have @xhyrom on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
@cla-bot check |
We require contributors to sign our Contributor License Agreement, and we don't have @xhyrom on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
The cla-bot has been summoned, and re-checked this pull request! |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
@xhyrom Before we go accepting this into the registry, could you say a bit more about how the Discord auth works for the Discord rich presence language server? |
I'm using https://github.com/vionya/discord-rich-presence which is a pretty nice library for it. You can check the code if you want. It just searches for discord ipc path and connects to it. |
I see, so it's just communicating with the local Discord instance over IPC? I think that assuages my concerns around security 🙂 |
@xhyrom Could you change the extension ID to be |
fixed |
Can you update here as well? https://github.com/zed-industries/extensions/pull/1217/files#diff-724e5177a66640ebdc9d051879ac354bbfd595c1b4d039bab887600964bb2023R231 Unfortunately GitHub won't let me push to this branch since the PR was created from a GitHub organization 😢 |
done :D |
@xhyrom I think we're almost there! Looks like the two version numbers don't align right now. |
You're right, sorry 😅😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Closes #499
GitHub repository: https://github.com/xhyrom/zed-discord-presence
It's done by LSP right now but once Zed gets normal extension support i'll rewrite it 👍