You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: I have not explicitly licensed the previous repository. I've contacted the author of gruvbox-ish by email, where they said "Of course you can port/modify or do whatever you want with it." If there's some extra requirement for licensing, I can ask for explicit licensing 👍
We require contributors to sign our Contributor License Agreement, and we don't have @LeoDog896 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.
@LeoDog896 There is a builtin gruvbox theme in zed editor.
Maybe it would be possible to port the improvements directly there?
I'm not familiar with changes/content, so not sure if it's easy and it won't break anything else, but would be cool to have solid gruvbox theme out of the box.
I could, though that doesn't seem appropriate given the themes changes and relative unpopularity in vscode - this theming extension only has 8 thousand downloads on VSCode.
@LeoDog896 There is a builtin gruvbox theme in zed editor. Maybe it would be possible to port the improvements directly there? I'm not familiar with changes/content, so not sure if it's easy and it won't break anything else, but would be cool to have solid gruvbox theme out of the box.
There was a similar discussion when the Rosé Pine theme was added. The official stance was not to change the built-in themes but to add an extension: zed-industries/zed#9151 (comment)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds the gruvbox-ish theme (original).
Note: I have not explicitly licensed the previous repository. I've contacted the author of
gruvbox-ishby email, where they said "Of course you can port/modify or do whatever you want with it." If there's some extra requirement for licensing, I can ask for explicit licensing 👍